Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XDR infiniband tools #1529

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

mazorasaf
Copy link
Contributor

@mazorasaf mazorasaf commented Dec 8, 2024

Add support SMI/GSI separation
This patch adds support SMI/GSI separation in XDR-supported HCAs by
introducing new APIs and structures in libibumad and libibmad.

In libibumad:

  • Add umad_get_smi_gsi_pairs() and umad_get_smi_gsi_pairs_by_name().
  • Introduce umad_ca_pair to represent SMI/GSI pairs.

In libibmad:

  • Add mad_rpc_open_port2() and mad_rpc_close_port2().
  • Return an ibmad_ports_pair structure from mad_rpc_open_port2().

In smpquery:

  • Demonstrate the new API to retrieve SMI/GSI details and properly
    use the SMI or GSI port based on the call type:
    • GMP calls (e.g., resolve_portid_str()) use the GSI port.
    • SMP calls (e.g., smp_query_via()) use the SMI port.

@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch 6 times, most recently from 29a5532 to 9bc7ec4 Compare December 12, 2024 12:55
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch 2 times, most recently from 1a64530 to 262c589 Compare December 19, 2024 13:58
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch 3 times, most recently from a1b60e3 to d07a077 Compare December 31, 2024 12:26
@jgunthorpe
Copy link
Member

This is not the correct format for a commit message, you need to follow the kernel style

@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch from d07a077 to dd8bba2 Compare January 7, 2025 10:53
@mazorasaf mazorasaf changed the title SMI/GSI pair suggestion Add support for SMI/GSI seperation Jan 7, 2025
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch from dd8bba2 to 810ce30 Compare January 9, 2025 16:19
@mazorasaf mazorasaf changed the title Add support for SMI/GSI seperation Add support for XDR infiniband tools Jan 9, 2025
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch 5 times, most recently from 976da0e to 1438c17 Compare January 13, 2025 08:05
Added functions:
 - umad_get_smi_gsi_pairs()
 - umad_get_smi_gsi_pairs_by_name()

Added structs:
 - umad_ca_pair to represent SMI/GSI pairs

Signed-off-by: Asaf Mazor <[email protected]>
Added functions:
 - mad_rpc_open_port2()
 - mad_rpc_close_port2()

Added structs:
 - ibmad_ports_pair for smi/gsi port details

Signed-off-by: Asaf Mazor <[email protected]>
Use the SMI or GSI port based on the call type:
 - GMP calls (e.g., resolve_portid_str()) use the GSI port.
 - SMP calls (e.g., smp_query_via()) use the SMI port.

Signed-off-by: Asaf Mazor <[email protected]>
@mazorasaf mazorasaf force-pushed the smi_gsi_pair_suggestion branch from 1438c17 to 52ecc03 Compare January 13, 2025 09:44
@rleon rleon merged commit b30c36d into linux-rdma:master Jan 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants